MaXal commented on code in PR #16921: URL: https://github.com/apache/echarts/pull/16921#discussion_r1168986067
########## src/chart/custom/CustomSeries.ts: ########## @@ -319,7 +319,7 @@ export type CustomSeriesRenderItem = ( api: CustomSeriesRenderItemAPI ) => CustomSeriesRenderItemReturn; -export interface CustomSeriesOption extends +export interface CustomSeriesOption<CallbackDataParams = never> extends Review Comment: I'm sorry for not getting back to you sooner. I had to provide `never` to minimize the needed change. If the "never" is omitted, it would require providing a generic argument to `CustomSeriesOption`, resulting in API changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org