andreasgerstmayr commented on code in PR #16547:
URL: https://github.com/apache/echarts/pull/16547#discussion_r1501141220
##########
src/scale/Log.ts:
##########
@@ -36,9 +36,28 @@ const roundingErrorFix = numberUtil.round;
const mathFloor = Math.floor;
const mathCeil = Math.ceil;
const mathPow = Math.pow;
-
const mathLog = Math.log;
+/**
+ * symmetric log, allowing negative values for logarithmic scales
+ */
+function symMathLog(x: number): number {
+ if (x >= 0) {
+ return mathLog(x);
+ }
Review Comment:
Good catch! I've updated the PR. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org
For additional commands, e-mail: commits-h...@echarts.apache.org
