sulivanganter commented on PR #19279: URL: https://github.com/apache/echarts/pull/19279#issuecomment-2131373737
Hi, @snukhulov I think there might be something wrong. If you change the number of samples in your example to 100,000, [updated exemple](https://echarts.apache.org/examples/en/editor.html?version=5.5.0&code=MYewdgzgLgBAZgJwKYEcCuSzAJ4wLwwDsADANwBQoksAtgIYDmYAllGgCZL4wBMZl4aPGYJoAZWZgkAETpQ63ANoBdClSEQkVdhKmz5S1QOrDRUXUgDycOJtgF-62Ju0XrtpPZgBWR4OfyCF5SAO4w-kgAFADkfDwAjAC0xADMySkAKvHeAFwpxDnExAB0RcQAWtEAlBRwIAgwkQA2njDM3GRtMAA8MPFlRaRtANTDVTAA3uQwME4w7HJcBKHhi5HQdEHFDJ4ZzDRR48NtNdOz_jBQ-0tdAPR9ZRQzLbAAbnRNGNyRALJyABbFCCSSI8GAAKhgfyggIACgBJCHwZDoTA4JFXA7jSH0JisDhIKrFKAgABizAAHkh2JEUqcZsw4I12r0AGwpACcMAAPtyugA-GAcgAsdMmZxmcBE4kkMjkdGKAAc0BB_pFFAsoEgADQwd6fLjHKVmNw2OzKekzGAucA6WX6BXK1XqzU6mCJSL6r6Ja1aW2mjxQKoWp4wAC-MCQTU0bSZkXaeETQpSwvGUytphlenlSpVao1i11YDQTSaIYlvtc9pzTvzrqLJbLlrD5Bb5BAiqu4G46curBaOUmlyQFKgg-iDui4e1ZxJICaV0Vg4mlwQzAYOwQ47oFOYEGiup3e9hIEkWq3Q7oLHoXbAg6gCC-EbDM-eSB2YHYy4rmrog8U0TAmAkQUoARASAAPAoElPEqYHjA0S-O61ogmBkHQbByhnC-Zy_uUIAgDQ_4ViuyAfJiSD3o-boUgAgruEDwp-I7_sQurxMoupSguSAID8ICcOO IRIHQADW5LcQgU7YRmK5QNgioUfBkjApwcGkQu1yURguq0fRjGcBSLFsco4ZnBxs74U0ABGICGUOcDCWwyDLtadCvEgNEMbiikTC-MDINA9Q-c-05nLpe4uXJCnjuRUmvjA2B0RFMCKMRFYzFFinRF6SAHulMCKiAwK3uOLRwFAeUZjMYB0AcMXXLq-7xRmNCSIOiS-M1Vr0HZ_SsflAD6BzsMwaCEfBQEgRBUHFDBVTRBW0lWr2GaZeOOWVVVhXFcw4ClUg5WbRmNV1fB5GNUd3Vte6nX5T1g59V1MxDdSo3jQhxBIZNqEzXNC0Zi2MzmTMmhrkgEBETJ-UnVl33Teh81PZc8lZU0sqXSDWpLhNgQVUjqogCEYjYDQNlNIOcAfJoSOJXpTF2f1VWuTQipo2ADDjq1YA9Rj5xgFIwBQAAco2EPwFTOr5b-FPSuY1byItXUrVaMPjohPpw2hs2wUja3wWzuX41j44bEEvME0TJNkxTEs00lDH0w9-O1azkgc_BXM80jVAC8Los29GktM9Llb-vLdCLWZrakEAA&pv=PR-19279%4077a3723) ,you can see the problem with returning just the absolute max value. This is just a suggestion and has not been tested: You need two values for each frame for min and max, something like this: ```javascript minmax: function (frame) { let turningPointMaxValue = -Infinity; let turningPointMinValue = Infinity; for (let i = 0; i < frame.length; i++) { const originalValue = frame[i]; if (originalValue > turningPointMaxValue) { turningPointMaxValue = originalValue; } if (originalValue < turningPointMinValue) { turningPointMinValue = originalValue; } } // Return an array with the min and max values return [turningPointMinValue, turningPointMaxValue]; } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
