robin-gerling commented on PR #19534: URL: https://github.com/apache/echarts/pull/19534#issuecomment-2134637768
Unfortunately, yes, those changes are pretty complex. If I understand your proposed changes, they would result in less functionality. However, those would simplify the logic. My current proposed solution considers the labels of other axes, too. Those need to be taken into account in case the name location is either start or end, because otherwise the labels would overlap with the name, as shown in the provided figure. On the left is the proposed solution, on the right is the result of a simpler computation within `estimateLabelUnionRect` which includes the computation of the name and the computation of the label. Therefore, by combining name and label to a single rect, the problem would not be solved for nameLocations start and end. <img width="665" alt="LabelNameOverlap" src="https://github.com/apache/echarts/assets/75605520/00e7b09f-3d22-4917-9e26-d3a4d9d8f9c3";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@echarts.apache.org For additional commands, e-mail: commits-h...@echarts.apache.org
