andregamma commented on issue #19959: URL: https://github.com/apache/echarts/issues/19959#issuecomment-2263051636
We need to have a better way to apply number formatters globally. Some languages don't format numbers as in English, and it is too much work to replace the default formatter in all components. This issue has been reported in some issues already: https://github.com/apache/echarts/issues/8294 https://github.com/apache/echarts/issues/4180 I think we have some ways to achieve that: - Have per-locale configurations and make the addCommas function use that as a source - Global user-provided formatter function - Use `Intl.FormatNumber` or `.toLocaleString()` using the current echarts locale The locale files already have some configuration for thousand separators, at first I thought it was used for number formatters but seems that is not the case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
