Ovilia commented on code in PR #20166:
URL: https://github.com/apache/echarts/pull/20166#discussion_r1843260106
##########
src/coord/polar/Polar.ts:
##########
@@ -234,7 +234,13 @@ class Polar implements CoordinateSystem,
CoordinateSystemMaster {
const r0 = this.r0;
return d2 <= r * r && d2 >= r0 * r0;
- }
+ },
+
+ // As the bounding box
+ x: this.cx - radiusExtent[1],
+ y: this.cy - radiusExtent[1],
+ width: radiusExtent[1] * 2,
+ height: radiusExtent[1] * 2
Review Comment:
It seems the `contain` (`d2 <= r * r && d2 >= r0 * r0`) assumes `r0 <= r`.
If `max(radiusExtent[0], radiusExtent[1])` is used here, maybe we should also
change other places, or just assumes `r0 <= r` until other requirement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
