plainheart commented on code in PR #21325:
URL: https://github.com/apache/echarts/pull/21325#discussion_r2456840034
##########
src/chart/helper/whiskerBoxCommon.ts:
##########
@@ -17,17 +17,17 @@
* under the License.
*/
-import createSeriesDataSimply from './createSeriesDataSimply';
import * as zrUtil from 'zrender/src/core/util';
-import {getDimensionTypeByAxis} from '../../data/helper/dimensionHelper';
-import {makeSeriesEncodeForAxisCoordSys} from '../../data/helper/sourceHelper';
-import type { SeriesOption, SeriesOnCartesianOptionMixin, LayoutOrient } from
'../../util/types';
-import type GlobalModel from '../../model/Global';
-import type SeriesModel from '../../model/Series';
-import type CartesianAxisModel from '../../coord/cartesian/AxisModel';
-import type SeriesData from '../../data/SeriesData';
import type Axis2D from '../../coord/cartesian/Axis2D';
+import type CartesianAxisModel from '../../coord/cartesian/AxisModel';
import { CoordDimensionDefinition } from '../../data/helper/createDimensions';
+import { getDimensionTypeByAxis } from '../../data/helper/dimensionHelper';
+import { makeSeriesEncodeForAxisCoordSys } from
'../../data/helper/sourceHelper';
+import type SeriesData from '../../data/SeriesData';
+import type GlobalModel from '../../model/Global';
+import type SeriesModel from '../../model/Series';
+import type { LayoutOrient, SeriesOnCartesianOptionMixin, SeriesOption } from
'../../util/types';
+import createSeriesDataSimply from './createSeriesDataSimply';
Review Comment:
These changes seem unrelated to this bug. I suggest recovering them,
including Line 175.
##########
src/chart/candlestick/candlestickVisual.ts:
##########
@@ -65,7 +65,11 @@ const candlestickVisual: StageHandler = {
let dataIndex;
while ((dataIndex = params.next()) != null) {
const itemModel = data.getItemModel(dataIndex);
- const sign = data.getItemLayout(dataIndex).sign;
Review Comment:
This non-null check can be removed as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
