fanwww opened a new pull request, #21425:
URL: https://github.com/apache/echarts/pull/21425

   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   ### What does this PR do?
   
   Fixes the issue where changing `labelLine.smooth` from `true` to `false` 
does not take effect in pie charts.
   
   ### Fixed issues
   
   - #21418: pie chart labelLine smooth configuration change from true to false 
not working
   
   
   ## Details
   
   ### Before: What was the problem?
   
   There was an issue with the `labelLine.smooth` configuration in pie charts 
(Issue #21418). When `smooth` was initially set to `true` and then changed to 
`false` dynamically (through `setOption` or in initial configuration), the 
label lines remained as smooth curves instead of reverting to straight lines. 
This prevented users from properly controlling the visual style of label lines.
   
   **Reproduction steps:**
   1. Set `labelLine.smooth: true` in pie chart configuration
   2. Update configuration with `labelLine.smooth: false`
   3. Observe that label lines still appear as smooth curves
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   ### After: How does it behave after the fixing?
   
   After the fix, the `labelLine.smooth` configuration now correctly responds 
to changes. When `smooth` is changed from `true` to `false`, the label lines 
immediately update to straight lines as expected. This ensures proper dynamic 
control over label line styling.
   
   **Verification:**
   - Setting `labelLine.smooth: false` now correctly renders straight label 
lines
   - Dynamic updates between `true` and `false` values work correctly
   - Backward compatibility is maintained for existing configurations
   
   <!-- ADD SCREENSHOT HERE IF APPLICABLE. -->
   
   
   ## Document Info
   
   One of the following should be checked.
   
   - [x] This PR doesn't relate to document changes
   - [ ] The document should be updated later
   - [ ] The document changes have been made in apache/echarts-doc#xxx
   
   
   ## Misc
   
   ### Security Checking
   
   - [ ] This PR uses security-sensitive Web APIs.
   
   ### ZRender Changes
   
   - [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
   
   ### Related test cases or examples to use the new APIs
   
   N.A.
   
   ### Merging options
   
   - [ ] Please squash the commits into a single one when merging.
   
   ### Other information


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to