Justin-ZS commented on PR #21579: URL: https://github.com/apache/echarts/pull/21579#issuecomment-4266849859
Thanks for the PR. The overall direction looks good, and the splitLine coverage extension to radius/angle/single plus added test pages is very helpful. I left one inline comment on AngleAxisView for a possible category-axis boundary edge case. Other than that, this looks solid. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
