Justin-ZS opened a new pull request, #21590:
URL: https://github.com/apache/echarts/pull/21590

   ## Brief Information
   
   This pull request is in the type of:
   
   - [x] bug fixing
   - [ ] new feature
   - [ ] others
   
   ### What does this PR do?
   
   Preserve `parallelAxis.areaSelectStyle` when persisted parallel-axis 
selections are rebuilt.
   
   ### Fixed issues
   
   - #21583: Parallel axis persisted selection ignores configured 
`areaSelectStyle`.
   
   ## Details
   
   ### Before: What was the problem?
   
   `ParallelAxisView` uses `areaSelectStyle` when creating a new axis 
selection, but the persisted covers are later rebuilt through 
`BrushController.updateCovers` without carrying over the active brush style. 
That rebuild path fell back to `DEFAULT_BRUSH_OPT`, so the selected area 
eventually changed back to the default light blue style instead of respecting 
the configured style.
   
   ### After: How does it behave after the fixing?
   
   `BrushController.updateCovers` now inherits from the currently enabled brush 
option before falling back to `DEFAULT_BRUSH_OPT`, so rebuilt covers keep the 
same `brushStyle`, `transformable`, and `removeOnClick` settings as the active 
controller. A regression test was added to lock this behavior in.
   
   ## Document Info
   
   One of the following should be checked.
   
   - [x] This PR doesn't relate to document changes
   - [ ] The document should be updated later
   - [ ] The document changes have been made in apache/echarts-doc#xxx
   
   ## Misc
   
   ### Security Checking
   
   - [ ] This PR uses security-sensitive Web APIs.
   
   ### ZRender Changes
   
   - [ ] This PR depends on ZRender changes (ecomfe/zrender#xxx).
   
   ### Related test cases or examples to use the new APIs
   
   - `npx jest --config test/ut/jest.config.cjs --coverage=false 
test/ut/spec/component/helper/BrushController.test.ts --runInBand`
   - `npm run checktype`
   - `npx eslint src/component/helper/BrushController.ts`
   
   ### Merging options
   
   - [x] Please squash the commits into a single one when merging.
   
   ### Other information
   
   N.A.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to