Justin-ZS opened a new pull request, #157:
URL: https://github.com/apache/echarts-examples/pull/157
## Summary
This restores PR preview bundle routing in the examples editor.
The regression was introduced in `f7ad877` (`use cdn hosted in asf server to
avoid csp issue`), where `getScripts()` started hardcoding `latestEChartsDir`.
As a result, URLs like `?version=PR-21590@0c0f466` were still recognized as PR
versions, but the editor loaded:
`/js/vendors/echarts/dist/echarts.min.js?_={commit}`
instead of switching to the preview host:
`https://echarts-pr-{PR_NUMBER}.surge.sh/dist/echarts.min.js`
This patch keeps the local behavior unchanged, while restoring the correct
branch selection for PR preview and normal/nightly versioned bundles.
## Test
- `npm ci --legacy-peer-deps`
- `npm run build`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
