This is an automated email from the ASF dual-hosted git repository.
Justin-ZS pushed a commit to branch codex/disable-pr-preview-comment
in repository https://gitbox.apache.org/repos/asf/echarts.git
The following commit(s) were added to
refs/heads/codex/disable-pr-preview-comment by this push:
new bc2ccbb56 chore(workflow): disable misleading PR preview comment
bc2ccbb56 is described below
commit bc2ccbb56704abb2455b7b4447f1b158d4c00237
Author: Justin-ZS <[email protected]>
AuthorDate: Wed Apr 22 09:55:32 2026 +0800
chore(workflow): disable misleading PR preview comment
---
.github/workflows/pr-preview.yml | 24 ++++++++++++++----------
1 file changed, 14 insertions(+), 10 deletions(-)
diff --git a/.github/workflows/pr-preview.yml b/.github/workflows/pr-preview.yml
index 4f8b6f3e9..41c0313f6 100644
--- a/.github/workflows/pr-preview.yml
+++ b/.github/workflows/pr-preview.yml
@@ -66,13 +66,17 @@ jobs:
export SURGE_DOMAIN=https://echarts-pr-$PR_NUMBER.surge.sh
npx surge --project ./package --domain $SURGE_DOMAIN --token
$SURGE_TOKEN
- - name: Create comment for PR preview
- uses: ./.actions/maintain-one-comment
- env:
- PR_NUMBER: ${{ steps.pr-metadata.outputs.NUMBER }}
- COMMIT_SHA_SHORT: ${{ steps.pr-metadata.outputs.COMMIT_SHA_SHORT }}
- with:
- body: |
- The changes brought by this PR can be previewed at:
https://echarts.apache.org/examples/editor?version=PR-${{ env.PR_NUMBER }}@${{
env.COMMIT_SHA_SHORT }}
- body-include: '<!-- ECHARTS_PR_PREVIEW -->'
- number: ${{ env.PR_NUMBER }}
+ # Disabled for now because the editor preview URL is misleading under the
+ # current website CSP policy. The preview bundle is still deployed to
+ # surge.sh, but `echarts.apache.org/examples/editor?version=PR-...`
+ # cannot reliably load it.
+ # - name: Create comment for PR preview
+ # uses: ./.actions/maintain-one-comment
+ # env:
+ # PR_NUMBER: ${{ steps.pr-metadata.outputs.NUMBER }}
+ # COMMIT_SHA_SHORT: ${{ steps.pr-metadata.outputs.COMMIT_SHA_SHORT }}
+ # with:
+ # body: |
+ # The changes brought by this PR can be previewed at:
https://echarts.apache.org/examples/editor?version=PR-${{ env.PR_NUMBER }}@${{
env.COMMIT_SHA_SHORT }}
+ # body-include: '<!-- ECHARTS_PR_PREVIEW -->'
+ # number: ${{ env.PR_NUMBER }}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
