susiwen8 opened a new pull request, #21600:
URL: https://github.com/apache/echarts/pull/21600

   ## Summary
   
   Fixes #21111.
   
   Toolbox `dataZoom` injects internal `dataZoom.select` components for the 
target axes. When a value axis uses `scale: true`, the generated dataZoom 
window is based on the axis extent, which already uses the stacked result 
dimension for stacked series. The filtering path still used the raw axis 
dimension, so stacked area data could be filtered away before rendering.
   
   This changes `AxisProxy` filtering to reuse the same axis-dimension 
selection helper used by extent calculation, keeping stacked data filtered by 
its rendered stack result dimension.
   
   ## Changes
   
   - Reuse `getDataDimensionsOnAxis` in dataZoom filtering.
   - Add a focused unit regression for toolbox-injected dataZoom with a scaled 
y-axis and stacked line data.
   - Add an HTML visual test for a toolbox dataZoom stacked confidence band.
   
   ## Validation
   
   - `./node_modules/.bin/jest --config test/ut/jest.config.cjs 
--coverage=false test/ut/spec/component/dataZoom --runInBand`
   - `npm run checktype`
   - `./node_modules/.bin/eslint src/component/dataZoom/AxisProxy.ts 
test/ut/spec/component/dataZoom/AxisProxy.test.ts`
   - `git diff --check -- src/component/dataZoom/AxisProxy.ts 
test/toolbox-dataZoom-stack-area.html 
test/ut/spec/component/dataZoom/AxisProxy.test.ts`
   - Chrome headless screenshot of `test/toolbox-dataZoom-stack-area.html`
   
   `npm run checkheader` still fails on pre-existing unrelated files missing 
headers; the new files are not listed in that failure.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to