mvanhorn opened a new pull request, #21618: URL: https://github.com/apache/echarts/pull/21618
## Summary When a pie chart series sets `label.position` to `'outside'` (an alias for `'outer'`) and `label.alignTo` to `'labelLine'`, the labelLine alignment pass was being silently bypassed. The fix is a 2-line change to also match `'outside'` at `labelLayout.ts:137`. ## Why this matters The rest of the pie label pipeline treats `outside` and `outer` as the same position value. The labelLayout alignment branch is the one place that hardcoded just `'outer'`, so users setting `position: 'outside'` (the documented alias) saw misaligned label lines while `position: 'outer'` worked correctly. Reporter pinpointed the exact line. ## Changes - `src/chart/pie/labelLayout.ts` - widen the position check to accept both `'outer'` and `'outside'` in `adjustSingleSide`. - `test/ut/spec/series/pie.test.ts` - add a regression test that asserts both `'outer'` and `'outside'` produce identical labelLine layouts when `alignTo: 'labelLine'`. ## Testing `npm run test:ut -- pie.test` (Karma + Jasmine). Fixes #21617 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
