100pah opened a new pull request, #21637:
URL: https://github.com/apache/echarts/pull/21637
<!-- Please fill in the following information to help us review your PR more
efficiently. -->
## Brief Information
This pull request is in the type of:
- [ ] bug fixing
- [ ] new feature
- [x] others
### What does this PR do?
<!-- USE ONE SENTENCE TO DESCRIBE WHAT THIS PR DOES. -->
Fix the implementation of #21586 .
- Remove some verbose and unnecessary code.
- Remove the breaking change to `visualMap[type='continuous'].formatter:
function () {}` - not necessary, and that breaking change can cause the
existing lables display incorrectly when labels touch.
The effect of #21586 :
<img width="665" height="153" alt="Image"
src="https://github.com/user-attachments/assets/8bce98b0-6dc1-4337-a35a-82aac7d1b118";
/>
Expected:
<img width="705" height="134" alt="Image"
src="https://github.com/user-attachments/assets/04e547cb-83a1-4ae0-a768-b7e3c7405e09";
/>
- Switch to a more comprehensive implementation - adjust the positions of
the two labels to avoid overlap. The previous approach (merging two labels) may
occupy extra horizontal space and may unexpectedly cause overlap with other
content.
The effect of #21586:
<img width="300" height="315" alt="11aa2"
src="https://github.com/user-attachments/assets/621e1062-5fc8-4615-b991-172186efbd4d";
/>
The effect of this PR:
<img width="300" height="315" alt="11aa"
src="https://github.com/user-attachments/assets/5bf3f9b4-2c17-4425-88ab-1c6d2322a8af";
/>
- Add visual test for `visualMap[type='continuous']`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
