KapilSachdev opened a new pull request, #163: URL: https://github.com/apache/echarts-examples/pull/163
## Unified SVG Icon System ### Problem `echarts-examples` currently manages SVG icons using two approaches: - `element-ui` CSS class-based icons (`el-icon-*`) - Hand-crafted inline SVG elements and standalone SVG files (e.g. sidebar chart list) ```html <!-- element-ui (Vue 2) --> <i class="el-icon-edit"></i> <el-button type="primary" icon="el-icon-edit">Edit</el-button> ``` As `element-ui` is Vue 2 only, migrating to `element-plus` drops the class-based icon API entirely (part of the larger Vue 3 migration #124 ). ```html <!-- element-plus (Vue 3) --> <el-icon><Edit /></el-icon> <Edit /> ``` Rather than adopting `element-plus` icons and adding yet another icon library, this is a good moment to consolidate. ### Why Not an Icon Library? The project uses several chart-specific icons that have no equivalent in standard icon libraries (Font Awesome, etc.). Using `element-plus` icons or any other external library would mean maintaining the current hybrid approach. ### Solution - Consolidate all icons into hand-crafted SVGs - Additionally built into a single SVG sprite file. ### What This PR Does - Removes dependency on `element-ui` class-based icons - Adds new SVG icons to keep feature parity for removed icons - Introduces SVG sprite build - Updates all icon usages across the project to use the new sprite approach -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
