KapilSachdev opened a new pull request, #166: URL: https://github.com/apache/echarts-examples/pull/166
## E2E Build Prerequisite Clarification Following Readme instructions for e2e fails with error `You need to run `node tool/build-example.js` before run this test.` ### Problem `echarts-examples` `README` instructs users to run: ```shell npm run build:examplelist ``` so that e2e tests can execute without issues using ```shell npm run test:e2e:esbuild:local ``` However, `build:examplelist` invokes `tool/build-example.js --no-thumb`, which skips the Puppeteer-driven screenshot flow. That also means the option JSON files under `public/data/option/*.json` are not generated, which invokes below code: https://github.com/apache/echarts-examples/blob/37bf0264b9c37242a2ca59e2a50e3077b46f56c9/e2e/main.js#L280-L290 ### Solution - Update the README for proper e2e setup requiring `npm run build:example` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
