[felix-dev] branch master updated: FELIX-6613 : ServicesCheck still reports services available after they are gone

[cziegeler]

This is an automated email from the ASF dual-hosted git repository.

cziegeler pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/felix-dev.git


The following commit(s) were added to refs/heads/master by this push:
     new 995a2fb51a FELIX-6613 : ServicesCheck still reports services available 
after they are gone
995a2fb51a is described below

commit 995a2fb51a5788063031edf0ebaf5cb5a3c0c9dc
Author: Carsten Ziegeler <cziege...@apache.org>
AuthorDate: Wed Jun 7 13:25:06 2023 +0200

    FELIX-6613 : ServicesCheck still reports services available after they are 
gone
---
 .../java/org/apache/felix/hc/generalchecks/ServicesCheck.java | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git 
a/healthcheck/generalchecks/src/main/java/org/apache/felix/hc/generalchecks/ServicesCheck.java
 
b/healthcheck/generalchecks/src/main/java/org/apache/felix/hc/generalchecks/ServicesCheck.java
index 1406e74126..4f2d9a831b 100644
--- 
a/healthcheck/generalchecks/src/main/java/org/apache/felix/hc/generalchecks/ServicesCheck.java
+++ 
b/healthcheck/generalchecks/src/main/java/org/apache/felix/hc/generalchecks/ServicesCheck.java
@@ -158,7 +158,7 @@ public class ServicesCheck implements HealthCheck {
             if(!entry.getValue().present()) {
                 missingServicesNames.add(entry.getKey());
             } else {
-                log.debug("Found {} services for '{}'", 
entry.getValue().getTrackingCount(), entry.getKey());
+                log.debug("Found at least one service for '{}'", 
entry.getKey());
             }
         }
         return missingServicesNames;
@@ -180,18 +180,13 @@ public class ServicesCheck implements HealthCheck {
         }
 
         public boolean present() {
-            return getTrackingCount() > 0;
-        }
-
-        public int getTrackingCount() {
-            return this.stracker.getTrackingCount();
+            return this.stracker.getService() != null;
         }
 
         @Override
         public void close() {
-            stracker.close();
+            this.stracker.close();
         }
-
     }
 
 }