This is an automated email from the ASF dual-hosted git repository.

ghenzler pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/felix-dev.git

commit f56606bdf53f533daf5f64862b3efd1ea6f16f5f
Merge: b48e5df019 18c4fb9741
Author: Georg Henzler <[email protected]>
AuthorDate: Thu Feb 5 11:32:48 2026 +0100

    Merge pull request #475 from 
apache/feature/FELIX-6819-allow-common-options-for-request-spec-items
    
    FELIX-6819 Allow common curl-like options that are applied to all 
configured requests

 .../felix/hc/generalchecks/HttpRequestsCheck.java  | 38 +++++++++++++------
 .../hc/generalchecks/HttpRequestsCheckTest.java    | 43 ++++++++++++++++++++--
 2 files changed, 66 insertions(+), 15 deletions(-)

diff --cc 
healthcheck/generalchecks/src/main/java/org/apache/felix/hc/generalchecks/HttpRequestsCheck.java
index 8037dec624,1623f4c248..26b93b2822
--- 
a/healthcheck/generalchecks/src/main/java/org/apache/felix/hc/generalchecks/HttpRequestsCheck.java
+++ 
b/healthcheck/generalchecks/src/main/java/org/apache/felix/hc/generalchecks/HttpRequestsCheck.java
@@@ -246,16 -238,17 +254,16 @@@ public class HttpRequestsCheck implemen
  
      }
  
-     private List<RequestSpec> getRequestSpecs(String[] requestSpecStrArr) {
-         List<RequestSpec> requestSpecs = new ArrayList<RequestSpec>();
+     private List<RequestSpec> getRequestSpecs(String[] requestSpecStrArr, 
String defaultRequestOptions) {
+         List<RequestSpec> requestSpecs = new ArrayList<>();
          for(String requestSpecStr: requestSpecStrArr) {
              try {
-                 RequestSpec requestSpec = new RequestSpec(requestSpecStr);
+                 RequestSpec requestSpec = new 
RequestSpec(defaultRequestOptions + " " + requestSpecStr);
                  requestSpecs.add(requestSpec);
              } catch(Exception e) {
 -                configErrors.critical("Invalid config: {}", requestSpecStr);
 -                configErrors.add(new ResultLog.Entry(Result.Status.CRITICAL, 
" "+e.getMessage(), e));
 -            }
 -
 +                configErrors.healthCheckError("Invalid config: {}", 
requestSpecStr);
 +                LOG.warn("Invalid config: "+e.getMessage(), e);
 +           }
          }
          return requestSpecs;
      }

Reply via email to