Copilot commented on code in PR #880: URL: https://github.com/apache/fesod/pull/880#discussion_r2940269459
########## fesod-sheet/src/main/java/org/apache/fesod/sheet/write/metadata/holder/WriteTableHolder.java: ########## @@ -17,6 +17,12 @@ * under the License. */ +/* + * This file is part of the Apache Fesod (Incubating) project, which was derived from Alibaba EasyExcel. + * + * Copyright (C) 2018-2024 Alibaba Group Holding Ltd. + */ Review Comment: The upstream/derivation notice is being added as a second top-level header block after the Apache license header. For ASF projects this can be harder to keep consistent and may not match the expected header format used by license-audit tooling. Consider folding this notice into the existing top-of-file header comment (so the license + attribution are a single contiguous header), or moving the attribution to the project NOTICE file if that matches the project’s licensing approach. ########## fesod-sheet/src/main/java/org/apache/fesod/sheet/util/BeanMapUtils.java: ########## @@ -18,7 +18,7 @@ */ /* - * This file is part of the Apache Fesod(incubating) project, which was derived from Alibaba EasyExcel. + * This file is part of the Apache Fesod (Incubating) project, which was derived from Alibaba EasyExcel. Review Comment: This PR is standardizing the attribution wording (e.g., spacing/capitalization) in at least one place. To prevent future drift across the large number of touched files, consider enforcing this header text via an automated check (e.g., an Apache RAT configuration / build-time header verification) so subsequent changes don’t reintroduce small formatting differences. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
