avikganguly01 commented on a change in pull request #462:  FINERACT-428 
Parallelization of Jobs :Parallelizing periodic accurual
URL: https://github.com/apache/fineract/pull/462#discussion_r254054620
 
 

 ##########
 File path: 
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java
 ##########
 @@ -1651,29 +1651,34 @@ public LoanTermVariationsData mapRow(final ResultSet 
rs, @SuppressWarnings("unus
     }
 
     private static final class LoanSchedulePeriodicAccrualMapper implements 
RowMapper<LoanScheduleAccrualData> {
-
-        public String schema() {
-            final StringBuilder sqlBuilder = new StringBuilder(400);
-            sqlBuilder
-                    .append("loan.id as loanId ,if(loan.client_id is 
null,mg.office_id,mc.office_id) as officeId,")
-                    .append("loan.accrued_till as accruedTill, 
loan.repayment_period_frequency_enum as frequencyEnum, ")
-                    .append("loan.interest_calculated_from_date as 
interestCalculatedFrom, ")
-                    .append("loan.repay_every as repayEvery,")
-                    .append("ls.installment as installmentNumber, ")
-                    .append("ls.duedate as duedate,ls.fromdate as fromdate 
,ls.id as scheduleId,loan.product_id as productId,")
-                    .append("ls.interest_amount as interest, 
ls.interest_waived_derived as interestWaived,")
-                    .append("ls.penalty_charges_amount as penalty, ")
-                    .append("ls.fee_charges_amount as charges, ")
-                    .append("ls.accrual_interest_derived as 
accinterest,ls.accrual_fee_charges_derived as 
accfeecharege,ls.accrual_penalty_charges_derived as accpenalty,")
-                    .append(" loan.currency_code as 
currencyCode,loan.currency_digits as currencyDigits,loan.currency_multiplesof 
as inMultiplesOf,")
-                    .append("curr.display_symbol as 
currencyDisplaySymbol,curr.name as 
currencyName,curr.internationalized_name_code as currencyNameCode")
-                    .append(" from m_loan_repayment_schedule ls ").append(" 
left join m_loan loan on loan.id=ls.loan_id ")
-                    .append(" left join m_product_loan mpl on mpl.id = 
loan.product_id")
-                    .append(" left join m_client mc on mc.id = loan.client_id 
").append(" left join m_group mg on mg.id = loan.group_id")
-                    .append(" left join m_currency curr on curr.code = 
loan.currency_code")
-                    .append(" left join m_loan_recalculation_details as 
recaldet on loan.id = recaldet.loan_id ");
-            return sqlBuilder.toString();
-        }
+        
+            public String schema() {
+                final StringBuilder sqlBuilder = new StringBuilder(400);
+                sqlBuilder
+                        .append("loan.id as loanId , mc.office_id as officeId, 
loan.loan_status_id as loanStatusId, ")
 
 Review comment:
   Hey Michael, good to see you. Thanks for the ?w=1 tip.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to