vorburger commented on issue #465: Fineract 614: Rates module URL: https://github.com/apache/fineract/pull/465#issuecomment-470767585 @ShruthiRajaram my question was just if the points which YOU (earlier, above) raised are now adressed? Voice Calls without any public written record here and no concrete concrete code review feedback which the contributor could react to and rectify, and mention of (nice!) other people who have not commented on this PR in 7 months (!) isn't really how the open source is supposed to work... ;-) Unless you (@ShruthiRajaram) have strong objections, I am inclined to merge this. My main goal isn't this particular functionality, but wanted to encourage contributors like @angelboxes who clearly are reactive to concentrate feedback here - we should not discourage and demotivate such contributions by taking SOOO long...
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
