bd2019us opened a new pull request #558: [FINERACT-747] change 
String.replaceAll() to replace() to improve performance
URL: https://github.com/apache/fineract/pull/558
 
 
   ## Description
   
   Fix ISSUE 
[#FINERACT-747](https://issues.apache.org/jira/browse/FINERACT-747). Change 
String.replaceAll() to replace() to improve performance if the string to be 
replaced is simply plain string but regex.
   
   ## Checklist
   Please make sure these boxes are checked before submitting your pull request 
- thanks!
   
   - [x ] Commit message starts with the issue number from 
https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
   
   - [x ] Coding conventions at 
https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have 
been followed.
   
   - [x ] API documentation at 
https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been 
updated with details of any API changes. __no need__
   
   - [x ] Integration tests have been created/updated for verifying the changes 
made. __does not influent test cases__
   
   - [x ] All Integrations tests are passing with the new commits.
   
   - [x ] Submission is not a "code dump".  (Large changes can be made "in 
repository" via a branch.  Ask on the list.)
   
   Our guidelines for code reviews is at 
https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to