vorburger commented on a change in pull request #593: Create one-touch deploy with docker URL: https://github.com/apache/fineract/pull/593#discussion_r296237547
########## File path: Dockerfile ########## @@ -0,0 +1,20 @@ +FROM bitnami/tomcat:7.0.94 as fineract + +USER root +RUN apt-get update -qq && apt-get install -y git openjdk-8-jdk wget +ENV JAVA_HOME /usr/lib/jvm/java-8-openjdk-amd64/jre + +RUN mkdir fineract +COPY . fineract + +WORKDIR fineract +RUN sed -i 's/localhost/fineractmysql/' ./fineract-provider/build.gradle Review comment: Is this for the mysql url? Why is it needed? Given how "./gradlew clean war" doesn't run any of the SQL tasks, can this be removed? If not, perhaps an inline comment to document what it's needed for? (FYI I am hoping to remove the Flyway related Gradle tasks, see https://issues.apache.org/jira/plugins/servlet/mobile#issue/FINERACT-765) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
