thesmallstar opened a new pull request #758: Added Maximum Line length check and Enforced checkstyle URL: https://github.com/apache/fineract/pull/758 ## Description Although the tools helped, after a lot of manual work I am left with 45 errors. These errors are mostly due to: 1. Extremely! extremely! long variable names. 2. Hard coded strings. Possible solution -> 1. I replace all occurrence of this variable/function to something smaller. 2. Replace hardcoded strings(mostly in tests asserts) with pre defined strings. If the suggestions look good, I will make those changes for the build to pass :) ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API. - [ ] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed. - [ ] API documentation at https://github.com/apache/fineract/blob/develop/api-docs/apiLive.htm has been updated with details of any API changes. - [ ] Integration tests have been created/updated for verifying the changes made. - [ ] All Integrations tests are passing with the new commits. - [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the list.) Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
