percyashu commented on a change in pull request #830:
URL: https://github.com/apache/fineract/pull/830#discussion_r429565613
##########
File path: fineract-provider/build.gradle
##########
@@ -276,7 +278,7 @@ configurations {
}
tasks.withType(JavaCompile) {
- options.compilerArgs += ["-Xlint:unchecked","-Xlint:cast","-Werror"] //
TODO FINERACT-959 (gradually) enable -Xlint:all (see "javac -help -X")
+ options.compilerArgs += ["-Xlint:unchecked","-Xlint:cast"] // TODO
FINERACT-959 (gradually) enable -Xlint:all (see "javac -help -X")
Review comment:
@vorburger thanks for the link I will configure error prone to help with
the 1000 warnings.
##########
File path:
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/StaffTest.java
##########
@@ -99,9 +101,10 @@ public void testStaffCreateMaxNameLength() {
map.put("firstname", Utils.randomNameGenerator("michael_", 42));
map.put("lastname", Utils.randomNameGenerator("Doe_", 46));
- StaffHelper.createStaffWithJson(requestSpec, responseSpec, new
Gson().toJson(map));
+ StaffHelper.createStaffWithJson(requestSpec,
responseSpecForValidationError, new Gson().toJson(map));
Review comment:
Ok will do those in seperate Pr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
