xurror commented on a change in pull request #1290:
URL: https://github.com/apache/fineract/pull/1290#discussion_r478707601
##########
File path:
fineract-provider/src/integrationTest/java/org/apache/fineract/integrationtests/RecurringDepositTest.java
##########
@@ -2774,11 +2774,11 @@ public void
testRecurringDepositQuarterlyCompoundingAndQuarterlyPosting_360_Days
Assertions.assertNotNull(recurringDepositProductId);
Integer recurringDepositAccountId =
applyForRecurringDepositApplication(clientId.toString(),
recurringDepositProductId.toString(),
- VALID_FROM, VALID_TO, SUBMITTED_ON_DATE, WHOLE_TERM,
expectedFirstDepositOnDate);
+ VALID_FROM, VALID_TO, submittedOnDate, WHOLE_TERM,
expectedFirstDepositOnDate);
Assertions.assertNotNull(recurringDepositAccountId);
HashMap modificationsHashMap =
this.recurringDepositAccountHelper.updateInterestCalculationConfigForRecurringDeposit(
- clientId.toString(), recurringDepositProductId.toString(),
recurringDepositAccountId.toString(), SUBMITTED_ON_DATE,
+ clientId.toString(), recurringDepositProductId.toString(),
recurringDepositAccountId.toString(), submittedOnDate,
VALID_FROM, VALID_TO, DAYS_360, WHOLE_TERM,
INTEREST_CALCULATION_USING_DAILY_BALANCE, QUARTERLY, QUARTERLY,
Review comment:
I think these variables could use the change to camel case too. They
don't look like some standard abbreviation. What do you think? Unless I don't
really get what this checkstyle is enforcing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
