varsvat commented on a change in pull request #133:
URL: https://github.com/apache/fineract-cn-mobile/pull/133#discussion_r594251411
##########
File path: app/src/main/res/layout/layout_nav_header.xml
##########
@@ -31,10 +32,12 @@
android:typeface="monospace"/>
<TextView
- android:id="@+id/textView"
+ android:id="@+id/nav_user_tenant"
android:layout_height="wrap_content"
android:layout_width="wrap_content"
android:textColor="@color/white"
- android:text="[email protected]"/>
+ android:paddingTop="@dimen/layout_padding_8dp"
Review comment:
Why have you added thi spadding here ? If you have done this to avoid
the overflow observed in nav bar, Adding a top padding will look good at latest
mobile with full screens as there , we see a overflow at the top of nav bar but
it works fine in the older mobiles where we used to have touch screen buttons.
For solving this issue , dont add padding, I have already opened a
[PR](https://github.com/apache/fineract-cn-mobile/pull/118) that solves this
issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
