bharathcgowda commented on pull request #1644: URL: https://github.com/apache/fineract/pull/1644#issuecomment-832686692
Hi @xurror @edcable Very pleased to have this addition to our loan module as it had been one of the most asked configurations by MFIs and other organizations. Did one round of high-level testing by taking the branch https://github.com/muellners/fineract/tree/rebase-semi and was happy with the schedule for the 'same as repayment' configuration. However, below are few observations that I found out, I hope it helps in improving this feature 1. Modify of loan account is not working with 'semi month' configuration ERROR:- " field is required Loan term frequency period type must match that of repayment frequency period type. -" 2. First date and last date tooltip is showing wrong info - minor issue, but could be misleading for initial users during configuration 3. Loan creation fails when 'First' and 'Last dates' are not mentioned at the product level, However, those fields are not mandatory to add at the Product level. - If we create the loan product without adding 'First' and 'Last dates', we cannot create a loan application 4. Validation for "Repaid Every" Number field. when 'Semi month' is selected Right now we can select 1 semi month, 3 semi month etc, which intern affecting the logic of loan term and number of repayments For example If we set "loan term" as 10 months and "repaid every" as 3 semi months "No of repayments" will be set to 30 instalments. Because of 'semi month' configuration, there would be 30 instalments for loan spread across 15 months. So this breaks the existing logic of "loan term" = "No of repayments"/"repaid every" We understand that user should know that semi months constitutes to 2 instalments per month, hence the number field should be frozen to 2 of "repaid every" when "semi month" is selected. 5. System doesn't allow to create loans with disbursement date greater than the first date set at the loan product level - for example, if we set the first date as 5th may 2021, the system doesn't allow to create a loan with disbursement date greater than 5th May 2021 6. The start date acts as a first repayment date, meaning even if we give the disbursement date as 1st Jan 2021, the system will still consider 5th may as the First repayment date(unless we specify the FRD while creating the loan application). Ideally, the system should follow instalments as per the frequency set 7. No option to change 'first date' and 'last date' at the loan account level, 5th and 6th issues are only because of configuration present only at the product level. 8. Interest portion is all zero when we set the interest calculation to 'daily' or 'same as repayment' with' Calculate interest for exact days in partial period' enabled - not sure if this is a bug or all the types have not been covered, as of now, system is not calculating interest when interest calculation to 'daily' or 'same as repayment' with' Calculate interest for exact days in partial period' enabled Please feel free to reach out to me if you need any clarification on any point, I'll be happy to help in ggt -  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
