BLasan commented on a change in pull request #1837:
URL: https://github.com/apache/fineract/pull/1837#discussion_r695643979
##########
File path:
fineract-provider/src/main/java/org/apache/fineract/infrastructure/core/service/GmailBackedPlatformEmailService.java
##########
@@ -73,15 +73,15 @@ public void sendDefinedEmail(EmailDetail emailDetails) {
props.put("mail.smtp.auth", "true");
props.put("mail.debug", "true");
- try {
- if (smtpCredentialsData.isUseTLS()) {
- // Needs to disable startTLS if the port is 465 in order to
send the email successfully when using the
- // smtp.gmail.com as the host
- if (smtpCredentialsData.getPort().equals("465")) {
- props.put("mail.smtp.starttls.enable", "false");
- }
- }
+ // these are the added lines
+ props.put("mail.smtp.starttls.enable", "true");
+ // props.put("mail.smtp.ssl.enable", "true");
Review comment:
What if the SMTP server uses SSL?
https://stackoverflow.com/questions/411331/using-javamail-with-tls
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
