ptuomola commented on a change in pull request #2012:
URL: https://github.com/apache/fineract/pull/2012#discussion_r777170786
##########
File path: .github/workflows/build.yml
##########
@@ -47,5 +56,24 @@ jobs:
run: |
sudo apt-get update
sudo apt-get install ghostscript -y
- - name: Build & Test
+
+ - name: Basic Auth Build & Test
+ env:
+ - FINERACT_SECURITY_BASICAUTH_ENABLED: true
+ - FINERACT_SECURITY_OAUTH_ENABLED: false
Review comment:
Do these variables actually do anything? It seems that we are hardcoding
the same parameters in the command line when starting the server for
oauth2-test and basictest etc? So it would seem that these are redundant...
correct?
##########
File path: oauth2-tests/build.gradle
##########
@@ -45,7 +45,7 @@ cargo {
}
startStopTimeout = 240000
containerProperties {
- property 'cargo.start.jvmargs', '-Dspring.profiles.active=oauth'
+ property 'cargo.start.jvmargs',
'-Dfineract.security.basicauth.enabled=false
-Dfineract.security.oauth.enabled=true -Dfineract.security.2fa.enabled=false'
Review comment:
Ie the environment is hardcoded here and these are the values used -
correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
