vidakovic commented on a change in pull request #2193:
URL: https://github.com/apache/fineract/pull/2193#discussion_r838955066
##########
File path:
integration-tests/src/test/java/org/apache/fineract/integrationtests/client/ClientTest.java
##########
@@ -65,7 +65,8 @@ Long create() {
fineract().clients.retrieveAll21(null, null, null, null, null,
null, null, null, 0, 1, null, null, false));
if (clients.getTotalFilteredRecords() > 0) {
// TODO rm long cast, see
https://issues.apache.org/jira/browse/FINERACT-1230
- return Optional.of((long) clients.getPageItems().get(0).getId());
+ return clients.getPageItems().stream().findFirst().map(item ->
item.getId().longValue());
+ // return Optional.of((long)
clients.getPageItems().stream().findFirst().get().getId());
Review comment:
Yup... one more round to demonstrate that the uploads are (well, at
least one unit test) working with the new client (as Michael suggested... this
was the initial blocker why we couldn't upgrade)... and with that I'll cleanup
this here too.
:+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
