logoutdhaval commented on code in PR #2310:
URL: https://github.com/apache/fineract/pull/2310#discussion_r864037589
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadReportingServiceImpl.java:
##########
@@ -162,9 +181,33 @@ public GenericResultsetData retrieveGenericResultset(final
String name, final St
final long startTime = System.currentTimeMillis();
LOG.info("STARTING REPORT: {} Type: {}", name, type);
- final String sql = getSQLtoRun(name, type, queryParams,
isSelfServiceUserReport);
+ String sql = getSQLtoRun(name, type, queryParams,
isSelfServiceUserReport);
+ final GenericResultsetData result;
+ Boolean paginationAllowed =
BooleanUtil.parseBoolean(queryParams.get(ReportingConstants.isPaginationAllowed));
- final GenericResultsetData result =
this.genericDataService.fillGenericResultSet(sql);
+ if (paginationAllowed) {
+ final List<ApiParameterError> dataValidationErrors = new
ArrayList<>();
Review Comment:
done
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadReportingServiceImpl.java:
##########
@@ -37,8 +40,15 @@
import java.util.Map;
import java.util.Set;
import javax.ws.rs.core.StreamingOutput;
+import liquibase.util.BooleanUtil;
Review Comment:
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
