galovics commented on code in PR #2314:
URL: https://github.com/apache/fineract/pull/2314#discussion_r865608624
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/GenericDataServiceImpl.java:
##########
@@ -169,7 +170,8 @@ public String generateJsonFromGenericResultsetData(final
GenericResultsetData gr
writer.append(
"[" + localDate.getYear() + ", " +
localDate.getMonthValue() + ", " + localDate.getDayOfMonth() + "]");
} else if (currColType.equals("DATETIME")) {
- final LocalDateTime localDateTime =
LocalDateTime.parse(currVal);
+ final DateTimeFormatter simpleDateFormat =
DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm:ss");
Review Comment:
Let's extract this into a constant and name the variable what it represent.
We don't need to waste an object creation every time we reach this execution
path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
