adamsaghy commented on code in PR #2344: URL: https://github.com/apache/fineract/pull/2344#discussion_r888696526
########## fineract-provider/src/main/resources/db/changelog/tenant/parts/0014_remove_unused_jobs.xml: ########## @@ -21,6 +21,9 @@ --> <databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.1.xsd";> <changeSet author="fineract" id="1"> + <sql> Review Comment: Blocker change! Please revert this. I believe we should never remove history entries! Also, please never modify an already existing and committed changeset! Reason: it will fail for everyone who already pulled that changeset -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
