vorburger commented on PR #2339: URL: https://github.com/apache/fineract/pull/2339#issuecomment-1146096893
I've now gone ahead and merged this - after I've convinced myself that this change does not actually break that `ClientLoanIntegrationTest`, by rebasing this change on today's `develop`, and seen it build green in #2346. (So the build failure seen on this PR was either a temporary flaky test, or was meanwhile fixed.) @temi-ro note how a project typically may not merge your 3 Git commits from this PR exactly as-is; what I did is called a "Squash and Merge" - combining your 3 separate commits into 1 new single commit, with slightly updating wording. You are still "attributed" as the author though. So congratulations on your very very first contribution to an open source project! 🥳 🎉 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
