galovics commented on PR #2437: URL: https://github.com/apache/fineract/pull/2437#issuecomment-1195163262
@fynmanoj > But there would be unintentional consequences to users who don’t want to be impacted by infra changes. Not sure about these "infra changes". Do you mind to elaborate? > Can you please integration test for one of the batch job honoring the job Params for batch size. Elaborate please. What batch size? > In the future, can similar pull requests be split into multiple pull request based on the feature it addresses, to make it easily reviewable That's always the goal but it's not possible for some cross cutting changes. Same for PostgreSQL support, I wasn't able to split it into smaller ones cause if I don't do it all the way through, builds are going to fail continuously. Same here. This is an all or nothing change. > Since it is a big change , I think we need to create 1.8.0 to separate from the cutting edge stuff going on develop, before this pull request get merged. To avoid large test cycle of 1.8.0 relese Respectfully disagree. If we start keeping changes on separate branches they will simply be not tested and forgotten/abandoned eventually and never getting merged. If we are lacking testing, let's work on improving those areas and fill the gaps. It's much better if we move forward with Fineract (or any product for that matter) instead of holding ourselves back from very valuable contributions from the community. My 2 cents. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
