galovics commented on code in PR #2459:
URL: https://github.com/apache/fineract/pull/2459#discussion_r931974739
##########
fineract-provider/src/main/java/org/apache/fineract/notification/service/NotificationReadPlatformServiceImpl.java:
##########
@@ -107,6 +107,13 @@ public void updateNotificationReadStatus() {
this.jdbcTemplate.update(sql, appUserId);
}
+ @Override
+ public void updateSingleNotificationReadStatus(Long id) {
+ String sql = "UPDATE notification_mapper SET is_read = true WHERE
is_read = false AND id = ?";
Review Comment:
I know the existing method uses native query but please don't introduce it
in one more method.
Please rely on JPA for updating the entity. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
