vidakovic commented on code in PR #2554:
URL: https://github.com/apache/fineract/pull/2554#discussion_r962077340
##########
fineract-provider/src/main/java/org/apache/fineract/adhocquery/domain/AdHoc.java:
##########
@@ -58,21 +65,6 @@ public final class AdHoc extends AbstractAuditableCustom {
@Column(name = "is_active", nullable = false)
private boolean isActive = false;
Review Comment:
2 things here:
- I think this variable should be named just "active"; because it is a base
type (boolean) Lombok will generate a "getter function" that is called
"isActive()"... which is better style... the prefix "is" in the variable is
kind of redundant, so let's try to get rid of it
- also: as this is a base type "boolean" the default value is anyway "false"
so let's remove that unnecessary assignment
The rest looks good and after these small changes we should be ready to
merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
