daviestobialex commented on code in PR #2547:
URL: https://github.com/apache/fineract/pull/2547#discussion_r967844818


##########
fineract-provider/src/main/resources/db/changelog/tenant/parts/0016_changed_unique_constraint_of_ref_no.xml:
##########
@@ -26,6 +26,6 @@
         <dropUniqueConstraint tableName="m_savings_account_transaction" 
constraintName="m_savings_account_transaction_ref_no_key"/>
     </changeSet>
     <changeSet author="fineract" id="1" context="mysql">
-        <dropUniqueConstraint tableName="m_savings_account_transaction" 
constraintName="ref_no"/>
+        <dropUniqueConstraint tableName="m_savings_account_transaction" 
constraintName="transaction_ref_no"/>

Review Comment:
   > Have you validated this with an empty 1.8 database? I think it's gonna 
fail due to the fact that the checksum is different. You should use 
validateChecksum in case you're touching older changesets
   
   This works on an empty 1.8 as the unique constraint name generated is the 
same.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to