adamsaghy commented on code in PR #2614:
URL: https://github.com/apache/fineract/pull/2614#discussion_r980278629


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##########
@@ -3893,6 +3893,23 @@ public ChangedTransactionDetail close(final JsonCommand 
command, final LoanLifec
         return changedTransactionDetail;
     }
 
+    public void handleChargebackTransaction(LoanTransaction 
chargebackTransaction,
+            final LoanLifecycleStateMachine loanLifecycleStateMachine) {
+        chargebackTransaction.updateLoan(this);
+
+        final LoanRepaymentScheduleTransactionProcessor 
loanRepaymentScheduleTransactionProcessor = this.transactionProcessorFactory
+                .determineProcessor(this.transactionProcessingStrategy);
+
+        
loanRepaymentScheduleTransactionProcessor.handleRefund(chargebackTransaction, 
getCurrency(), getRepaymentScheduleInstallments(),

Review Comment:
   overpaid portion is unhandled
   E.g.:
   Disbursed amount is 1000, outstanding is 1000
   Repaid 700, outstanding is 300
   Chargeback 700, outstanding should be 0 and overpaid by 400



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to