adamsaghy commented on code in PR #2614:
URL: https://github.com/apache/fineract/pull/2614#discussion_r982422287
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/LoanTransaction.java:
##########
@@ -127,9 +127,15 @@ public class LoanTransaction extends
AbstractAuditableWithUTCDateTimeCustom {
@OneToMany(cascade = CascadeType.ALL, orphanRemoval = true, fetch =
FetchType.LAZY, mappedBy = "loanTransaction")
private Set<LoanCollateralManagement> loanCollateralManagementSet = new
HashSet<>();
+ @Column(name = "is_full_chargeback", nullable = false)
+ private boolean fullChargeback;
Review Comment:
@josehernandezfintecheandomx I think we should not introduce this field on
transaction level... if you need this information we can calculate it from the
transactions and on the UI, but for most of the transactions this field is
irrelevant..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]