galovics commented on code in PR #2608: URL: https://github.com/apache/fineract/pull/2608#discussion_r991458574
########## fineract-doc/src/docs/en/chapters/documentation/transaction-idempotency.adoc: ########## @@ -0,0 +1,118 @@ += Introducing Transaction Idempotency into Fineract + +For banks, Apache Fineract is introducing transaction idempotency, business and +effective date configuration as an addition to currenty supported + +* System date Review Comment: Is there a reason to mixing up the idempotency concept with dates? I don't get it. ########## fineract-doc/src/docs/en/chapters/documentation/transaction-idempotency.adoc: ########## @@ -0,0 +1,118 @@ += Introducing Transaction Idempotency into Fineract + +For banks, Apache Fineract is introducing transaction idempotency, business and +effective date configuration as an addition to currenty supported + +* System date +* Tenant date +* User-provided date + +Transaction idempotency is the scenario in POST and PUT API requests when if the +caller sends retry of a request multiple times, the result is equivalent to +single request modification. If there is no transaction idempotency, the user +retries the request N times, the result will end up having N resources with N +different URIs created on server. + +In simple terms transaction idempotency is required in case of: + +* Retry of write operation in case of timeout due to: + * VM Crash + * JVM Crash + * Thread exception + * APIs crashe Review Comment: typo ########## fineract-doc/src/docs/en/chapters/documentation/transaction-idempotency.adoc: ########## @@ -0,0 +1,118 @@ += Introducing Transaction Idempotency into Fineract + +For banks, Apache Fineract is introducing transaction idempotency, business and +effective date configuration as an addition to currenty supported + +* System date +* Tenant date +* User-provided date + +Transaction idempotency is the scenario in POST and PUT API requests when if the +caller sends retry of a request multiple times, the result is equivalent to +single request modification. If there is no transaction idempotency, the user +retries the request N times, the result will end up having N resources with N +different URIs created on server. + +In simple terms transaction idempotency is required in case of: + +* Retry of write operation in case of timeout due to: + * VM Crash + * JVM Crash + * Thread exception + * APIs crashe + +* Duplicate writes Review Comment: Wrong indentation. ########## fineract-doc/src/docs/en/chapters/documentation/transaction-idempotency.adoc: ########## @@ -0,0 +1,118 @@ += Introducing Transaction Idempotency into Fineract + +For banks, Apache Fineract is introducing transaction idempotency, business and +effective date configuration as an addition to currenty supported + +* System date +* Tenant date +* User-provided date + +Transaction idempotency is the scenario in POST and PUT API requests when if the Review Comment: Not only POST and PUT. DELETE/PATCH too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
