galovics commented on code in PR #2659:
URL: https://github.com/apache/fineract/pull/2659#discussion_r995496825
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/dataqueries/service/ReadWriteNonCoreDataServiceImpl.java:
##########
@@ -183,6 +192,116 @@ public DatatableData retrieveDatatable(final String
datatable) {
return datatableData;
}
+ @Override
+ public List<JsonObject> queryDataTable(String datatable, String
columnFilter, String valueFilter, String resultColumns) {
+ Arrays.asList(datatable, columnFilter, valueFilter,
resultColumns).forEach(SQLInjectionValidator::validateDynamicQuery);
+ List<String> resultColumnNames =
Stream.of(resultColumns.split(",")).toList();
Review Comment:
No question. I'm simply saying to replace Stream.of(..).toList() with an
Arrays.asList since you don't use the Stream API anyhow and it's just a waste
of resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
