[fineract] branch develop updated: FINERACT-1926: Lift loan status validation for buyback

[adamsaghy]

This is an automated email from the ASF dual-hosted git repository.

adamsaghy pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git


The following commit(s) were added to refs/heads/develop by this push:
     new 3cec11196 FINERACT-1926: Lift loan status validation for buyback
3cec11196 is described below

commit 3cec11196452f499a72f1e536046a472d6c6fac4
Author: Adam Saghy <adamsa...@gmail.com>
AuthorDate: Tue Jun 6 16:41:41 2023 +0200

    FINERACT-1926: Lift loan status validation for buyback
---
 .../fineract/investor/service/ExternalAssetOwnersWriteServiceImpl.java | 3 ---
 1 file changed, 3 deletions(-)

diff --git 
a/fineract-investor/src/main/java/org/apache/fineract/investor/service/ExternalAssetOwnersWriteServiceImpl.java
 
b/fineract-investor/src/main/java/org/apache/fineract/investor/service/ExternalAssetOwnersWriteServiceImpl.java
index 4b1920f89..afb1cc01a 100644
--- 
a/fineract-investor/src/main/java/org/apache/fineract/investor/service/ExternalAssetOwnersWriteServiceImpl.java
+++ 
b/fineract-investor/src/main/java/org/apache/fineract/investor/service/ExternalAssetOwnersWriteServiceImpl.java
@@ -80,7 +80,6 @@ public class ExternalAssetOwnersWriteServiceImpl implements 
ExternalAssetOwnersW
     public CommandProcessingResult saleLoanByLoanId(JsonCommand command) {
         final JsonElement json = fromApiJsonHelper.parse(command.json());
         Long loanId = command.getLoanId();
-        LocalDate settlementDate = getSettlementDateFromJson(json);
         LoanIdAndExternalIdAndStatus loanIdAndExternalIdAndStatus = 
fetchLoanDetails(loanId);
         validateLoanStatus(loanIdAndExternalIdAndStatus);
         ExternalAssetOwnerTransfer externalAssetOwnerTransfer = 
createSaleTransfer(loanId, command.json(),
@@ -97,8 +96,6 @@ public class ExternalAssetOwnersWriteServiceImpl implements 
ExternalAssetOwnersW
         Long loanId = command.getLoanId();
         LocalDate settlementDate = getSettlementDateFromJson(json);
         ExternalId externalId = getTransferExternalIdFromJson(json);
-        LoanIdAndExternalIdAndStatus loanIdAndExternalIdAndStatus = 
fetchLoanDetails(loanId);
-        validateLoanStatus(loanIdAndExternalIdAndStatus);
         validateSettlementDate(settlementDate);
         ExternalAssetOwnerTransfer effectiveTransfer = 
fetchAndValidateEffectiveTransferForBuyback(loanId, settlementDate);
         ExternalAssetOwnerTransfer externalAssetOwnerTransfer = 
createBuybackTransfer(effectiveTransfer, settlementDate, externalId);