[fineract] branch develop updated: FINERACT-1926: Fix buyback `effective date to`

[arnold]

This is an automated email from the ASF dual-hosted git repository.

arnold pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/fineract.git


The following commit(s) were added to refs/heads/develop by this push:
     new af062d1ac FINERACT-1926: Fix buyback `effective date to`
af062d1ac is described below

commit af062d1ac5160d96be24c0bab6f41865f6a7259a
Author: Adam Saghy <adamsa...@gmail.com>
AuthorDate: Wed Jun 7 13:32:39 2023 +0200

    FINERACT-1926: Fix buyback `effective date to`
---
 .../investor/cob/loan/LoanAccountOwnerTransferBusinessStep.java        | 2 +-
 .../investor/cob/loan/LoanAccountOwnerTransferBusinessStepTest.java    | 3 +--
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git 
a/fineract-investor/src/main/java/org/apache/fineract/investor/cob/loan/LoanAccountOwnerTransferBusinessStep.java
 
b/fineract-investor/src/main/java/org/apache/fineract/investor/cob/loan/LoanAccountOwnerTransferBusinessStep.java
index ff8a7aeb2..57c098bfd 100644
--- 
a/fineract-investor/src/main/java/org/apache/fineract/investor/cob/loan/LoanAccountOwnerTransferBusinessStep.java
+++ 
b/fineract-investor/src/main/java/org/apache/fineract/investor/cob/loan/LoanAccountOwnerTransferBusinessStep.java
@@ -103,7 +103,7 @@ public class LoanAccountOwnerTransferBusinessStep 
implements LoanCOBBusinessStep
     private ExternalAssetOwnerTransfer buybackAsset(final Loan loan, final 
LocalDate settlementDate,
             ExternalAssetOwnerTransfer buybackExternalAssetOwnerTransfer, 
ExternalAssetOwnerTransfer activeExternalAssetOwnerTransfer) {
         activeExternalAssetOwnerTransfer.setEffectiveDateTo(settlementDate);
-        
buybackExternalAssetOwnerTransfer.setEffectiveDateTo(buybackExternalAssetOwnerTransfer.getEffectiveDateFrom());
+        buybackExternalAssetOwnerTransfer.setEffectiveDateTo(settlementDate);
         buybackExternalAssetOwnerTransfer
                 
.setExternalAssetOwnerTransferDetails(createAssetOwnerTransferDetails(loan, 
buybackExternalAssetOwnerTransfer));
         
externalAssetOwnerTransferRepository.save(activeExternalAssetOwnerTransfer);
diff --git 
a/fineract-investor/src/test/java/org/apache/fineract/investor/cob/loan/LoanAccountOwnerTransferBusinessStepTest.java
 
b/fineract-investor/src/test/java/org/apache/fineract/investor/cob/loan/LoanAccountOwnerTransferBusinessStepTest.java
index be1aa36d6..a492ac953 100644
--- 
a/fineract-investor/src/test/java/org/apache/fineract/investor/cob/loan/LoanAccountOwnerTransferBusinessStepTest.java
+++ 
b/fineract-investor/src/test/java/org/apache/fineract/investor/cob/loan/LoanAccountOwnerTransferBusinessStepTest.java
@@ -172,7 +172,6 @@ public class LoanAccountOwnerTransferBusinessStepTest {
         ExternalAssetOwnerTransfer firstResponseItem = 
Mockito.mock(ExternalAssetOwnerTransfer.class);
         ExternalAssetOwnerTransfer secondResponseItem = 
Mockito.mock(ExternalAssetOwnerTransfer.class);
         
when(firstResponseItem.getStatus()).thenReturn(ExternalTransferStatus.BUYBACK);
-        when(firstResponseItem.getEffectiveDateFrom()).thenReturn(actualDate);
         List<ExternalAssetOwnerTransfer> response = List.of(firstResponseItem);
         
when(externalAssetOwnerTransferRepository.findAll(any(Specification.class), 
eq(Sort.by(Sort.Direction.ASC, "id"))))
                 .thenReturn(response);
@@ -185,7 +184,7 @@ public class LoanAccountOwnerTransferBusinessStepTest {
         final Loan processedLoan = underTest.execute(loanForProcessing);
         // then
         verify(externalAssetOwnerTransferRepository, 
times(1)).findAll(any(Specification.class), eq(Sort.by(Sort.Direction.ASC, 
"id")));
-        
verify(firstResponseItem).setEffectiveDateTo(firstResponseItem.getEffectiveDateFrom());
+        verify(firstResponseItem).setEffectiveDateTo(actualDate);
         verify(externalAssetOwnerTransferRepository, 
times(2)).save(externalAssetOwnerTransferArgumentCaptor.capture());
         verify(secondResponseItem).setEffectiveDateTo(actualDate);
         verify(externalAssetOwnerTransferLoanMappingRepository, 
times(1)).deleteByLoanIdAndOwnerTransfer(1L, secondResponseItem);