josehernandezfintecheandomx opened a new pull request, #3338: URL: https://github.com/apache/fineract/pull/3338
## Description In order to implement [Periodic Accrual accounting for Savings products](https://cwiki.apache.org/confluence/plugins/servlet/mobile?contentId=66852861#content/view/66852861) we have added a flag to Savings Charges to It can be recognized or not as accrual income. The API for charges was updated to support this new parameter `recognizedAsAccrualIncome` and It will be only required for the Savings charges, the other charges for other products remain as current and the default value for this will be `false` Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284). - API Charge screenshot <img width="960" alt="Screenshot 2023-07-29 at 12 02 49" src="https://github.com/apache/fineract/assets/44206706/48c8737a-230f-448f-8405-465e6968bdd0";> - Integration Tests <img width="2029" alt="Screenshot 2023-07-29 at 13 52 27" src="https://github.com/apache/fineract/assets/44206706/eca352dc-7265-424a-81c4-8581c6d52b79";> ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update unit or integration tests for verifying the changes made. - [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions. - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.) FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
