adamsaghy commented on code in PR #3351:
URL: https://github.com/apache/fineract/pull/3351#discussion_r1282900194
##########
fineract-core/src/main/java/org/apache/fineract/portfolio/savings/data/SavingsAccountTransactionData.java:
##########
@@ -117,7 +117,7 @@ public static SavingsAccountTransactionData
interestPosting(final SavingsAccount
savingsAccountTransactionType.getValue().longValue(),
savingsAccountTransactionType.getCode(),
savingsAccountTransactionType.getValue().toString());
return new SavingsAccountTransactionData(amount.getAmount(), date,
savingsAccount.getId(), savingsAccountTransactionEnumData,
- isReversed, null, isManualTransaction, lienTransaction);
+ isReversed, null, isManualTransaction, lienTransaction, date);
Review Comment:
Does that mean the transaction date is end of month (31th July) or start of
month (1st of Aug)?
However, my concern is with the negative use cases. What would be the
outcome if the job which posts the interest will not be executed on 1st of Aug,
but got executed on 2nd of Aug. I reckon the transaction date would be still
1st of Aug (if the interest posting happens on 1st day of the month), but the
submitted on date should be 2nd of Aug in this case, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
