taskain7 commented on code in PR #3352:
URL: https://github.com/apache/fineract/pull/3352#discussion_r1286701896
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/serialization/JsonParserHelper.java:
##########
@@ -459,28 +462,31 @@ public LocalTime extractLocalTimeNamed(final String
parameterName, final JsonEle
return value;
}
- public LocalDateTime extractLocalDateTimeNamed(final String parameterName,
final JsonElement element, final String timeFormat,
+ public LocalDateTime extractLocalDateTimeNamed(final String parameterName,
final JsonElement element, String timeFormat,
final Locale clientApplicationLocale, final Set<String>
parametersPassedInCommand) {
LocalDateTime value = null;
- String timeValueAsString = null;
+ String timeValueAsString;
if (element.isJsonObject()) {
final JsonObject object = element.getAsJsonObject();
if (object.has(parameterName) &&
object.get(parameterName).isJsonPrimitive()) {
parametersPassedInCommand.add(parameterName);
try {
- DateTimeFormatter timeFormtter =
DateTimeFormatter.ofPattern(timeFormat);
+ timeFormat = timeFormat.replace("y", "u");
Review Comment:
it's still necessary since I haven't changed the type everywhere. The rest
will be coming in a furhter PR.
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/serialization/JsonParserHelper.java:
##########
@@ -518,17 +524,25 @@ public static LocalDate convertFrom(final String
dateAsString, final String para
return convertDateTimeFrom(dateAsString, parameterName, dateFormat,
clientApplicationLocale).toLocalDate();
}
- public static LocalDateTime convertDateTimeFrom(final String
dateTimeAsString, final String parameterName, final String dateTimeFormat,
+ public static LocalDate convertFrom(final String dateAsString, final
String parameterName, final DateFormat dateFormat,
+ final Locale clientApplicationLocale) {
+
+ return convertDateTimeFrom(dateAsString, parameterName,
dateFormat.getDateFormat(), clientApplicationLocale).toLocalDate();
+ }
+
+ private static LocalDateTime convertDateTimeFrom(final String
dateTimeAsString, final String parameterName, String dateTimeFormat,
final Locale clientApplicationLocale) {
validateDateFormatAndLocale(parameterName, dateTimeFormat,
clientApplicationLocale);
LocalDateTime eventLocalDateTime = null;
if (StringUtils.isNotBlank(dateTimeAsString)) {
try {
+ dateTimeFormat = dateTimeFormat.replace("y", "u");
Review Comment:
it's still necessary since I haven't changed the type everywhere. The rest
will be coming in a furhter PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
