josehernandezfintecheandomx commented on PR #3350: URL: https://github.com/apache/fineract/pull/3350#issuecomment-1699716373
> 1. HttpMessageNotReadableErrorController is okay, however i reckon we need an erorr handler to handle DateTimeParseException and provide back a valid error message with a hint about the problem. Something like this: > HTTP 400 - Bad request > Error message: Invalid date was provided. The date must match with the “yyyy-MMMM-dd” date format. > Can you please write an ErrorMapper for the DateTimeParseException? > 2. ExternalAssetOwnersApiResourceSwagger.java -> Please undo the changes, they are not required. , Spring will generate automatically the swagger > 3. ExternalAssetOwnersApiResource.java -> searchInvestorData method @ApiResponses annotation can be removed as well > 4. Please enhance your tests cases: > > * assertNotNull(response); is not enough… Please write assertion for each value and check the value is matching with the expectations > * Test case when submitted on from date of search request date format is invalid -> I dont see this test case to be covered! **Done those changes and PR updated please review it, Thanls** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
